Add support to scala #324
Merged
Add support to scala #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate-hermes
requested review from
ale7714
and removed request for
codeclimate-hermes
codeclimate-hermes
requested review from
larkinscott
and removed request for
codeclimate-hermes
filipesperandio
requested review from
codeclimate-hermes
and removed request for
larkinscott
codeclimate-hermes
requested review from
wilson
and removed request for
codeclimate-hermes
wfleming
approved these changes
Jun 22, 2018
| LANGUAGE = "scala".freeze | ||
| PATTERNS = ["**/*.sc", "**/*.scala"].freeze | ||
| DEFAULT_MASS_THRESHOLD = 60 | ||
| DEFAULT_FILTERS = [].freeze |
There was a problem hiding this comment.
Do you think we need to ignore imports by default? That's a common source of false positives in many languages.
There was a problem hiding this comment.
I think I haven't hit issues with the current DEFAULT_MASS_THRESHOLD. Improving the spec so I can adjust this! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: https://github.com/codeclimate/app/issues/7173